Skip to content

fix: meeting proposal conversion error #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SebastianKrupinski merged 1 commit into from
Jan 15, 2026
Merged

fix: meeting proposal conversion error #7831

SebastianKrupinski merged 1 commit into from
Jan 15, 2026
+6 −0

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Jan 6, 2026 •
edited
Loading

Summary

  • Adjusted proposal logic to delete existing time blocker to prevent duplicate uid error
"message": "Calendar object with uid already exists in this calendar collection.",
    "exception": "{\"class\":\"Sabre\\DAV\\Exception\\BadRequest\",\"message\":\"Calendar object with uid already exists in this calendar collection.\",\"code\":0,\"file\":\"/var/www/nextcloud/master/apps/dav/lib/CalDAV/CalDavBackend.php:1370\",\"trace\":\"#0 /var/www/nextcloud/master/lib/public/AppFramework/Db/TTransactional.php(45): OCA\\DAV\\CalDAV\\CalDavBackend->OCA\\DAV\\CalDAV\\{closure}()\\n#1 /var/www/nextcloud/master/apps/dav/lib/CalDAV/CalDavBackend.php(1356): OCA\\DAV\\CalDAV\\CalDavBackend->atomic()\\n#2 /var/www/nextcloud/master/3rdparty/sabre/dav/lib/CalDAV/Calendar.php(199): OCA\\DAV\\CalDAV\\CalDavBackend->createCalendarObject()\\n#3 /var/www/nextcloud/master/3rdparty/sabre/dav/lib/DAV/Server.php(1098): Sabre\\CalDAV\\Calendar->createFile()\\n#4 /var/www/nextcloud/master/apps/dav/lib/CalDAV/CalendarImpl.php(203): Sabre\\DAV\\Server->createFile()\\n#5 /var/www/nextcloud/master/apps/dav/lib/CalDAV/CalendarImpl.php(213): OCA\\DAV\\CalDAV\\CalendarImpl->createFromStringInServer()\\n#6 /var/www/nextcloud/master/apps/calendar/lib/Service/Proposal/ProposalService.php(366): OCA\\DAV\\CalDAV\\CalendarImpl->createFromString()\\n#7 /var/www/nextcloud/master/apps/calendar/lib/Controller/ProposalController.php(194): OCA\\Calendar\\Service\\Proposal\\ProposalService->convertProposal()\\n#8 /var/www/nextcloud/master/lib/private/AppFramework/Http/Dispatcher.php(205): OCA\\Calendar\\Controller\\ProposalController->convert()\\n#9 /var/www/nextcloud/master/lib/private/AppFramework/Http/Dispatcher.php(118): OC\\AppFramework\\Http\\Dispatcher->executeController()\\n#10 /var/www/nextcloud/master/lib/private/AppFramework/App.php(153): OC\\AppFramework\\Http\\Dispatcher->dispatch()\\n#11 /var/www/nextcloud/master/lib/private/Route/Router.php(321): OC\\AppFramework\\App::main()\\n#12 /var/www/nextcloud/master/ocs/v1.php(61): OC\\Route\\Router->match()\\n#13 /var/www/nextcloud/master/ocs/v2.php(8): require_once('...')\\n#14 {main}\"}",
    "CustomMessage": "Calendar object with uid already exists in this calendar collection."

Testing

  • Create meeting proposal with at least one attendee and one date (this will create a time blocker in the calendar)
  • After proposal is created convert one of the date to a meeting (does not require a vote) the conversion should fail with a error without this PR

@SebastianKrupinski
fix: meeting proposal conversion error
311d792 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski self-assigned this Jan 6, 2026
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Jan 6, 2026
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

GVodyanov
GVodyanov approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SebastianKrupinski
Copy link
Contributor Author

SebastianKrupinski commented Jan 15, 2026

/backport to stable6.1

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Jan 15, 2026
@SebastianKrupinski SebastianKrupinski merged commit fbcc51b into main Jan 15, 2026
40 checks passed
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Jan 15, 2026
@SebastianKrupinski SebastianKrupinski deleted the fix/meeting-proposal-object-exists branch January 15, 2026 13:05
@backportbot backportbot bot mentioned this pull request Jan 15, 2026
Merged
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GVodyanov GVodyanov GVodyanov approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@SebastianKrupinski SebastianKrupinski

Labels

3. to review Waiting for reviews

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SebastianKrupinski @GVodyanov